Skip to content

gh-132971: update shutil.which doc #133067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 10, 2025

Conversation

985025074
Copy link
Contributor

@985025074 985025074 commented Apr 28, 2025

Hello! This is my first contribution to Python. If there’s anything incorrect, please forgive me.


📚 Documentation preview 📚: https://cpython-previews--133067.org.readthedocs.build/

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 28, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Apr 28, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Apr 28, 2025
@picnixz picnixz changed the title gh-132971:update shutil.which doc gh-132971: update shutil.which doc Apr 28, 2025
@picnixz picnixz changed the title gh-132971: update shutil.which doc gh-132971: update shutil.which doc Apr 28, 2025
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@donBarbos donBarbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
but please don't force-push; it makes reviewing harder. Moreover, all commits are squashed upon merge anyway, so there's no need for the PR/branch to be cluttered with amendment commits. Source: devguide.

Comment on lines 460 to 461
specified path directly and does not search the directories listed in *path*
or in the system's :envvar:`PATH` environment variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wrap this line so that it doesn't exceed the length of the line

Suggested change
specified path directly and does not search the directories listed in *path*
or in the system's :envvar:`PATH` environment variable.
specified path directly and does not search the directories listed in
*path* or in the system's :envvar:`PATH` environment variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will follow that next time.Thank you.

@985025074 985025074 requested a review from donBarbos April 30, 2025 02:35
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note directive is considered too loud. A simple paragraph is enough.

@985025074 985025074 requested a review from picnixz May 10, 2025 06:59
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you for your contribution @985025074.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 10, 2025
@serhiy-storchaka serhiy-storchaka merged commit d13d5fd into python:main May 10, 2025
32 checks passed
@miss-islington-app
Copy link

Thanks @985025074 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2025

GH-133803 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 10, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2025

GH-133804 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 10, 2025
picnixz pushed a commit that referenced this pull request May 10, 2025
gh-132971: Update shutil.which() docs (GH-133067)
(cherry picked from commit d13d5fd)

Co-authored-by: Kokona <[email protected]>
picnixz pushed a commit that referenced this pull request May 10, 2025
gh-132971: Update shutil.which() docs (GH-133067)
(cherry picked from commit d13d5fd)

Co-authored-by: Kokona <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants